Mark Forum as Read - changing forums to be marked as Unread

This morning I noticed that every forum for me was marked as Unread.

When I enter a forum all threads appear to be read then when I exit the forum it is now marked as read.

After doing this with several forums and realizing that the threads were all mis-marked I tried going to the main forum page and clicking "mark as read" for all forums.

This then undid all the forums that were not showing new posts and marked them as unread again.

After doing some testing.

If I open a game forum that has subforums, hitting the Mark as Read will make the the Subforums all unread and the threads in the main forum marked as Read.

This seems to be the main "Bug" which would probably be why if I hit "Mark as Read" for all Forums on the site, it will mark each "Subforum" as Unread.

Uh oh. I made a fix to a previous bug in the marked unread code, but I wonder if it was hiding another issue. I'll go back over this.

Happening to me too

Yah, looks like I introduced a but that was missed on staging. I'm working on a fix.

hehe introduced a butt.

Thank you for all that you do for this community

There's a fix on staging. If folks can help test, I can get it on prod ASAP.

If I go into a game it works for all threads and subforums but if I do it from /forums it doesn't update all forums

If I go into those forums on Staging that claim to be unread (though they aren't) and then go into them and mark them as read, they stay marked as read.

Ok, there's a bunch of new code up to try to fix the reported issues.

Code has been pushed to prod. Hopefully this resolves the marked read/unread issues. Let me know if more are found.

I got a fresh batch of forums marked unread after that code was pushed to prod. Sorry.

To be clear, is that new actions are causing unwanted behavior, or the state of the data after the push is problematic? Because how new posts are calculated and the bug, things may look funky initially, but making a forum as read, visiting threads, or marking posts as unread should even out the state of the data.

For me, nearly every game forum and a handful of general ones got marked as unread after the update. Since they do become unread after ether visiting or marking them as unread, the code itself does seem to be working - just the initial state is off.

(Also, some games had unread status despite every thread in them displaying as read, but marking the forums as read did help.)

I see games I post to marked as unread, but when I go into the game the thread is marked as read. Clicking "Mark all as read" clears the game unread status

So you're saying when you make a post, the thread is showing up as unread? Even if you're the last post?

In the Games Forum, but not in the individual forum for each game. Yes.

Same.

Also mark forum as read is slow I believe. Thanks.

Likewise (I stand corrected about everything working as intended). Similarly only happens on the main forums, not game ones.

Hm... unfortunately, I'm out of town until Monday, but I'll see if I get a chance to do any coding work over this weekend. I can't seem to replicate this behavior myself (I can hit mark as read on any forum without any issue so far), so what I'll ask is if someone can get this to happen on staging consistently, let me know (if on a different user, what user) and tell me how you're doing it. I can use that to try to test the behavior on staging and see if I can't figure out why.